search

reapit / foundations

Foundations platform mono repo
57 stars 21 forks source link

Messages received have lower case property ID's #7665

Closed rochellelevy closed 1 year ago

rochellelevy commented 2 years ago

Describe the bug We are receiving messages with a propertyID in lower case and our system rejects the messages. This is intermittent.

To Reproduce N/A

Expected behaviour PropertyID's should be in upper case

Screenshots

Example below:

{ "id": "CND2201583", "created": "2022-09-08T13:05:14Z", "modified": "2022-09-08T13:05:14Z", "start": "2022-09-09T17:00:00Z", "end": "2022-09-09T18:00:00Z", "typeId": "VW", "description": "", "recurring": false, "recurrence": null, "cancelled": false, "followUp": { "due": "2022-09-10", "responseId": "", "notes": "" }, "propertyId": "cnd150204", "organiserId": "NJRT", "negotiatorIds": [ "NJRT" ], "officeIds": [ "CND" ], "attendee": { "id": "CND222174", "type": "applicant", "contacts": [ { "id": "CND22001922", "name": "", "homePhone": null, "workPhone": null, "mobilePhone": "", "email": "", "fromArchive": false } ] }, "accompanied": true, "virtual": false, "negotiatorConfirmed": true, "attendeeConfirmed": true, "propertyConfirmed": true, "fromArchive": false, "extrasField": {}, "_eTag": "\"F673272916E62F15D19838BFF44B2476\"", "_links": { "self": { "href": "/appointments/CND2201583" }, "type": { "href": "/configuration/appointmentTypes/VW" }, "organiser": { "href": "/negotiators/NJRT" }, "property": { "href": "/properties/cnd150204" }, "offices": { "href": "/offices/?id=CND" }, "negotiators": { "href": "/negotiators/?id=NJRT" }, "attendee": { "href": "/applicants/CND2201583" } }, "_embedded": null, "metadata": {} }

Device (please complete the following information for web issues): N/A

Additional context Add any other context about the problem here.

Specification

github-actions[bot] commented 2 years ago

Thank you for taking the time to report a bug. We prioritise bugs depending on the severity and implications, so please ensure that you have provided as much information as possible. If you haven’t already, it really helps us to investigate the bug you have reported if you provide ‘Steps to Replicate’ and any associated screenshots. Please ensure any personal information from the production database is obscured when submitting screenshots. This issue will be reviewed in our weekly refinement sessions and assigned to a specific project board. We may also update the ticket to request additional information, if required. For more information on our processes, please click here

plittlewood-rpt commented 2 years ago

Hi @rochellelevy this is happening because of the underlying data in the database. I'm trying to see where this data is coming from as the property itself has an uppercase property code. Do you know by any chance how that appointment was added as it doesn't seem to have been done via the Platform APIs. There's records going back quite a long way in this format, but it's definitely intermittent

plittlewood-rpt commented 2 years ago

This looks to be a bug in AgencyCloud itself. If you type the property code in lowercase when creating an appointment it is saved in the database in that format. I'll get this logged and let you have the reference. We'll review this anyway as we can look at transforming this data in the APIs regardless as they should be uppercase in all circumstances

plittlewood-rpt commented 2 years ago

Internal AC ref: ACB-1619

rochellelevy commented 2 years ago

I dont know Pete, I am assuming this was created by the negotiator in their reapit calendar in agency cloud

github-actions[bot] commented 2 years ago

This issue has been updated and moved to our ‘Near Term’ column (typically completed within 0 - 4 months). We have assessed the effort required and outlined a technical specification - please take the time to review this detail. When we're ready to schedule the issue, it will be assigned to the relevant board where you can continue to track its progress to completion. For more information on our processes, please click here