Property PublicBrochureURL are invalid for many properties

[rajeshwl]

Describe the bug Some of the property Public Brochure URL's are not working. Can you please check whether the issue is in your end. Shared some of the Property ID's and URL's.

PropertyId : publicBrochureUrl BAT220173 : https://assets.reapit.net/csp/live/pdf.php?p=BAT220173&t=S BAT220149 : https://assets.reapit.net/csp/live/pdf.php?p=BAT220149&t=S BAT220137 : https://assets.reapit.net/csp/live/pdf.php?p=BAT220137&t=S BAT220134 : https://assets.reapit.net/csp/live/pdf.php?p=BAT220134&t=S BAT220125 : https://assets.reapit.net/csp/live/pdf.php?p=BAT220125&t=S

Client: Crisp Cowley(CSP) Endpoint Used: properties

Expected to have a valid URL are the link to be empty.

Specification

• Project: Reapit.Services.Properties
• Update PublicUriHelper to take the following into account and only display brochure URI if all points validate:
  • Internet Advertising must be enabled
  • Status must be one of 'FA', 'SA' if property is sales (or dual marketed) - use enum
  • Status must be one of 'LA', 'UA', 'TA', 'AA', 'AC', 'TC' if property is lettings (or dual marketed) - use enum
  • Property must have a brochure assigned (dictated by presence of pDetails in prp.extra
• Update tests in appropriate places, adding new tests as necessary

[github-actions[bot]]

Thank you for taking the time to report a bug. We prioritise bugs depending on the severity and implications, so please ensure that you have provided as much information as possible. If you haven’t already, it really helps us to investigate the bug you have reported if you provide ‘Steps to Replicate’ and any associated screenshots. Please ensure any personal information from the production database is obscured when submitting screenshots. This issue will be reviewed in our weekly refinement sessions and assigned to a specific project board. We may also update the ticket to request additional information, if required. For more information on our processes, please click here

[ianyoung]

Coincidental timing. I've just come across the same issue. Examples:

PropertyId : publicBrochureUrl GUE141237: https://assets.reapit.net/sau/live/pdf.php?p=GUE141237&t=S GUE141613: https://assets.reapit.net/sau/live/pdf.php?p=GUE141613&t=S GUE141806: https://assets.reapit.net/sau/live/pdf.php?p=GUE141806&t=S GUE150592: https://assets.reapit.net/sau/live/pdf.php?p=GUE150592&t=S GUE150585: https://assets.reapit.net/sau/live/pdf.php?p=GUE150585&t=S

Client: Savills Endpoint Used: properties

[HollyJoyPhillips]

Hi @ianyoung Can you confirm the field name please because we have both a 'url' field (on the Marketing screen) and a Property Brochure URL: publicBrochureUrl?

[ianyoung]

I was referring to the publicBrochureUrl field. However, in my case it may very well be because it is a UAT environment and the property brochures aren't attached...

[rajeshwl]

@HollyJoyPhillips , We use the field selling->publicBrochureUrl and letting->publicBrochureUrl in the property data.

[HollyJoyPhillips]

Thank you for verifying. We'll take a look and come back to you.

[github-actions[bot]]

This issue has been updated and moved to our ‘Near Term’ column (typically completed within 0 - 4 months). We have assessed the effort required and outlined a technical specification - please take the time to review this detail. When we're ready to schedule the issue, it will be assigned to the relevant board where you can continue to track its progress to completion. For more information on our processes, please click here

[plittlewood-rpt]

Hi @rajeshwl - this is happening because the properties are no longer on the market and as a result the brochures should not be public anymore. The URL shouldn't really be being surfaced in these cases as you point out, so we'll get that looked at when we can.