reapit / foundations

Foundations platform mono repo
57 stars 21 forks source link

Relet Flag #8374

Open elizabethhamlin opened 1 year ago

elizabethhamlin commented 1 year ago

Under the property there is a Relet flag, please can this be added

Specification

plittlewood-rpt commented 1 year ago

Hi @elizabethhamlin thanks for reaching out. I've just spoken to our developers to understand this functionality a bit better. In the database we store the relet date rather than a flag, so I'd suggest we surface the date in the analytics schema, and then put the onus on you as a data consumer to infer that as a boolean value (ie if date is populated true else false). Will that work for you?

elizabethhamlin commented 1 year ago

Hi @plittlewood-rpt thanks for this. Yes, I think that this will work. As long as I can link this to the tenancy table so that I can work out how many new lets are relets for example, that is great.

Thanks

Lill

github-actions[bot] commented 1 year ago

This issue has been updated and moved to our ‘Near Term’ column (typically completed within 0 - 4 months). We have assessed the effort required and outlined a technical specification - please take the time to review this detail. When we're ready to schedule the issue, it will be assigned to the relevant board where you can continue to track its progress to completion. For more information on our processes, please click here

plittlewood-rpt commented 1 year ago

Hi @elizabethhamlin I'm just implementing this and was trying to test it against your production data but it doesn't look like it's actually being used and I've checked your system and the re-let functionality isn't turned on so I just wanted to check what you mean by the 'relet' flag - can you provide a bit more information please as I might have misinterpreted what you are asking for here. Thanks

github-actions[bot] commented 1 year ago

We have recently requested additional information relating to the issue you have raised. Please can you take the time to review this ticket and where applicable, provide the information requested. For more information on our processes, please click here

elizabethhamlin commented 1 year ago

Hi @plittlewood-rpt So when I run a tenancy report is Reapit there is this flag -

image

With the options of true and false. I assume that if it is set to true, this will pull up any new tenancies that have started that have had tenancies that have finished on them previously. I basically need to know, of new tenancies that have started, which ones have been let out before.

Let me know if you need anymore.

plittlewood-rpt commented 1 year ago

HI @elizabethhamlin thanks for confirming. That means we've hit a snag I'm afraid. There is currently no scope for exposing custom fields in the analytics schema as it's a standard schema designed to work with all customer databases. The Relet flag was added specifically to your build and isn't present for any other customers. I'll take this back to our PO for consideration

github-actions[bot] commented 1 year ago

The nature of this request requires product direction and therefore we have moved this issue into our ‘Not Ready’ column whilst we obtain the information/direction required. This issue will be updated when a product decision has been made. For more information on our processes, please click here

elizabethhamlin commented 1 year ago

Hi @plittlewood-rpt I am aware that this is available for other customers as LSL have use of this. I don't understand why that cannot be exposed as it is quite a simple flag.

plittlewood-rpt commented 1 year ago

Hi @elizabethhamlin it's because it makes use of a customisable component inside of AgencyCloud and as such even though LSL might have access to something similar, it will have been implemented in a different manner (I cannot see the same checkbox in their system for instance).

plittlewood-rpt commented 1 year ago

To re-review on next refinement session

elizabethhamlin commented 1 year ago

@plittlewood-rpt Hi Pete, any update on this one? Thanks

plittlewood-rpt commented 1 year ago

Hi @elizabethhamlin not yet, unfortunately exposing custom fields is quite a big enhancement as everything we do needs to be consistent across the board so we have to look at the right mechanism to do this.

plittlewood-rpt commented 1 year ago

Hi @elizabethhamlin we are going to run a spike to review what options we have for exposing this data as part of ticket #8747. We are going to do this in the next sprint which starts on Monday so we'll have a better idea in the next couple of weeks about how we can proceed with this. Thanks for your patience.

elizabethhamlin commented 1 year ago

Thanks @plittlewood-rpt

plittlewood-rpt commented 1 year ago

Hi @elizabethhamlin I've started looking at the linked ticket in the current sprint and it's brought me back round to giving this issue some thought again. I've logged into your build and I can't see that you're using the Relet functionality in AgencyCloud so any new relets won't be having the flag set. Is your understanding that this functionality should be enabled? If so we should probably start with figuring out what's happened there I think

elizabethhamlin commented 1 year ago

Hi @plittlewood-rpt yes, my understanding is that when I do a report for new tenancies that have started and I select the Relet flag, this will show me only properties that have had a tenancy in them before so are therefore a relet. We have the option to select this in our power reports and therefore I didn't realise that this was something that had to be enabled as I thought it was just a formula to pull out these properties that had had tenancies before.

plittlewood-rpt commented 1 year ago

Have reached out to customer CSM about this - need to understand why the functionality is not enabled in the customer's build

github-actions[bot] commented 11 months ago

This issue has been updated and moved to our ‘Near Term’ column (typically completed within 0 - 4 months). We have assessed the effort required and outlined a technical specification - please take the time to review this detail. When we're ready to schedule the issue, it will be assigned to the relevant board where you can continue to track its progress to completion. For more information on our processes, please click here

elizabethhamlin commented 4 months ago

Hi Please can I have an update on this?

plittlewood-rpt commented 4 months ago

hi @elizabethhamlin sorry for the radio silence on this item. I've just checked your system and you still don't have the re-let functionality enabled. This means anything we do in the analytics schema isn't going to make any difference for you anyway. That said, depending on how you are defining a relet, you can do something like this

with tenCountDates as 
(
    SELECT 
        COUNT(*) AS num,
        MIN(start_date) AS earliest_tenancy_date, 
        property_id 
    FROM tenancies 
    WHERE status IN ('Current', 'Finished')
    GROUP BY property_id
)

SELECT
    -- Note that only current/finished tenancies are included in this count
    -- as presumably we wouldn't consider a new tenancy a relet if previous entries
    -- were cancelled tenancies etc
    tenCountDates.num AS total_tenancies,

    -- Show earliest tenancy date from current/finished tenancies
    -- You can use this data to join back to the original tenancy
    -- to determine if the applicant is the same
    tenCountDates.earliest_tenancy_date,
    properties.code as property_code,
    CASE
        WHEN tenCountDates.num > 1 THEN True
        ELSE False
    END as relet,
    tenancies.*,
FROM tenancies
LEFT JOIN tenCountDates ON tenancies.property_id = tenCountDates.property_id
LEFT JOIN properties ON tenancies.property_id = properties.id
WHERE 
    start_date > ADD_MONTHS(GETDATE(), -2) AND 
    status = 'Current'

This will give you a view of tenancies with a flag whether or not it is a relet along with a count of previous tenancies on the same property that are:

Does this give you what you need? I will reach out to your CSM again to see if they can speak to you regarding the built in functionality.

elizabethhamlin commented 4 months ago

Hi Pete

I think that we are along the same lines.

Basically I need to know if a property has had a tenancy (current or finished) on it before or if it has not. Ideally if it has had a tenancy on it before, it will only could as a relet if that tenancy ended less than 6 months ago.

Thanks

Lill

Elizabeth Hamlin MARLA Reporting and Systems Manager 07443 188920 @.**@.>

[Text Description automatically generated]

Lomond is a group of leading Lettings and Sales Agents across the UK. Lomond is the trading name of Chianti Holdings Ltd. Registered office address 70 St. Mary Axe, London, EC3A 8BE. Registered in England and Wales. Registered Company No. 13075482.

This email is confidential and intended solely for the use of the individual to whom it is addressed. Any views or opinions presented are solely those of the author and do not necessarily represent those of Lomond. If you are not the intended recipient, be advised that you have received this email in error and that any use, dissemination, forwarding, printing, or copying of this email is strictly prohibited. If you have received this email in error please contact the sender. Finally, the recipient should check this email and any attachments for the presence of viruses. The company accepts no liability for any damage caused by any virus transmitted by this email.

From: Pete Littlewood @.> Sent: Thursday, February 22, 2024 5:38 PM To: reapit/foundations @.> Cc: Elizabeth Hamlin @.>; Mention @.> Subject: Re: [reapit/foundations] Relet Flag (Issue #8374)

You don't often get email from @.**@.>. Learn why this is importanthttps://aka.ms/LearnAboutSenderIdentification

hi @elizabethhamlinhttps://github.com/elizabethhamlin sorry for the radio silence on this item. I've just checked your system and you still don't have the re-let functionality enabled. This means anything we do in the analytics schema isn't going to make any difference for you anyway. That said, depending on how you are defining a relet, you can do something like this

with tenCountDates as

(

SELECT

    COUNT(*) AS num,

    MIN(start_date) AS earliest_tenancy_date,

    property_id

FROM tenancies

WHERE status IN ('Current', 'Finished')

GROUP BY property_id

)

SELECT

-- Note that only current/finished tenancies are included in this count

-- as presumably we wouldn't consider a new tenancy a relet if previous entries

-- were cancelled tenancies etc

tenCountDates.num AS total_tenancies,

-- Show earliest tenancy date from current/finished tenancies

-- You can use this data to join back to the original tenancy

-- to determine if the applicant is the same

tenCountDates.earliest_tenancy_date,

properties.code as property_code,

CASE

    WHEN tenCountDates.num > 1 THEN True

    ELSE False

END as relet,

tenancies.*,

FROM tenancies

LEFT JOIN tenCountDates ON tenancies.property_id = tenCountDates.property_id

LEFT JOIN properties ON tenancies.property_id = properties.id

WHERE

start_date > ADD_MONTHS(GETDATE(), -2) AND

status = 'Current'

This will give you a view of tenancies with a flag whether or not it is a relet along with a count of previous tenancies on the same property that are:

Does this give you what you need? I will reach out to your CSM again to see if they can speak to you regarding the built in functionality.

— Reply to this email directly, view it on GitHubhttps://github.com/reapit/foundations/issues/8374#issuecomment-1959941444, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AY6KCUF2LXXO3T4T4UOR2VTYU57ANAVCNFSM6AAAAAAUATBGZ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJZHE2DCNBUGQ. You are receiving this because you were mentioned.Message ID: @.**@.>>

plittlewood-rpt commented 4 months ago

Thanks - in that case the query I sent yesterday should do the trick. You can adjust the statuses as required if you want to exclude or include more data when determining whether or not a previous tenancy has been associated to the same property. Let me know how you get on.

elizabethhamlin commented 4 months ago

Hi Pete

I wouldn’t even know where to begin to add this script in. Do I add to power BI or into Reapit power reports?

Thanks

Lill

Elizabeth Hamlin MARLA Reporting and Systems Manager 07443 188920 @.**@.>

[Text Description automatically generated]

Lomond is a group of leading Lettings and Sales Agents across the UK. Lomond is the trading name of Chianti Holdings Ltd. Registered office address 70 St. Mary Axe, London, EC3A 8BE. Registered in England and Wales. Registered Company No. 13075482.

This email is confidential and intended solely for the use of the individual to whom it is addressed. Any views or opinions presented are solely those of the author and do not necessarily represent those of Lomond. If you are not the intended recipient, be advised that you have received this email in error and that any use, dissemination, forwarding, printing, or copying of this email is strictly prohibited. If you have received this email in error please contact the sender. Finally, the recipient should check this email and any attachments for the presence of viruses. The company accepts no liability for any damage caused by any virus transmitted by this email.

From: Pete Littlewood @.> Sent: Friday, February 23, 2024 2:09 PM To: reapit/foundations @.> Cc: Elizabeth Hamlin @.>; Mention @.> Subject: Re: [reapit/foundations] Relet Flag (Issue #8374)

You don't often get email from @.**@.>. Learn why this is importanthttps://aka.ms/LearnAboutSenderIdentification

Thanks - in that case the query I sent yesterday should do the trick. You can adjust the statuses as required if you want to exclude or include more data when determining whether or not a previous tenancy has been associated to the same property. Let me know how you get on.

— Reply to this email directly, view it on GitHubhttps://github.com/reapit/foundations/issues/8374#issuecomment-1961391800, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AY6KCUFMVPNZEJ366DPMAMDYVCPIDAVCNFSM6AAAAAAUATBGZ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRRGM4TCOBQGA. You are receiving this because you were mentioned.Message ID: @.**@.>>