Endpoint request: Clearing funds in Reapit & Fixflo

katedeedman commented 1 year ago

Hello Reapit!

Our mutual client, DJ Alexander, has been in touch with us about clearing funds in Fixflo. They've requested a workflow in FF whereby the reserved funds would be cleared by the PM if the works order is removed in Fixflo. This would then sync into Reapit. Do you have an endpoint for this?

Thanks in advance!

-Kate (Product Manager at FF)

Specification

Project: Reapit.Services.WorksOrders
Add new decimal? reserveAmount to WorksOrderItemModel that maps to workdet.maintfloatwith the following comment:The amount of funds to be held back by the agent in landlord payment runs to cover the cost of any works required by the works order item`
This should be both readable and writeable. Write side should follow the validations and behaviours. Consider using the repository in the validation class to simplify validation that usually sits in the handlers, as this means all validation rules sit in one class which is easier to manage

Write validations

It should not be possible to set the reserveAmount to a negative value
It should only be possible to set or change the reserveAmount to when chargeTo = landlord
It should not be possible to set or change the reserveAmount when the works order status is cancelled

Write behaviour

When works order status is changed to cancelled, workdet.maintfloat should set to zero (for all the items on the works order)
Patch to work like any other field. Null means do nothing, else set to value provided
When chargeTo changes from landlord to tenant (as part of a patch) the reserve funds on the item should be zeroed

github-actions[bot] commented 1 year ago

The nature of this request requires product direction and therefore we have moved this issue into our ‘Not Ready’ column whilst we obtain the information/direction required. This issue will be updated when a product decision has been made. For more information on our processes, please click here

HollyJoyPhillips commented 1 year ago

Product decision required from the Foundations team as it relates to transactional data.

neilpellowe commented 1 year ago

This request forms part of a larger roadmap discovery item to review our current Endpoint offering and any additional areas we may consider opening up. Accounts and related fields will be reviewed as part of this discovery. Once complete, tickets will be updated.

HollyJoyPhillips commented 1 year ago

Moving into refinement as confirmed with Foundations no direct relation to client accounts (transactional data).

HollyJoyPhillips commented 1 year ago

Emailed Foundations for further clarification.

plittlewood-rpt commented 1 year ago

Hi @katedeedman we need to just do some further investigation on this to ensure there'll be no impact to other areas of the system. We'll do this as part of the linked ticket above and then come back to this item and add a proper specification.

plittlewood-rpt commented 9 months ago

Spec added to ticket ready for refinement this week.

plittlewood-rpt commented 9 months ago

@neilpellowe we've scoped this out and can proceed. Please can you schedule.

github-actions[bot] commented 9 months ago

This issue has been updated and moved to our ‘Near Term’ column (typically completed within 0 - 4 months). We have assessed the effort required and outlined a technical specification - please take the time to review this detail. When we're ready to schedule the issue, it will be assigned to the relevant board where you can continue to track its progress to completion. For more information on our processes, please click here

katedeedman commented 9 months ago

Hi!

Has this been released now? Can you let me know what the new endpoint is called?

Thanks!

-Kate

github-actions[bot] commented 9 months ago

It looks like you have commented on a closed issue. If your comment relates to a bug or feature request, please open a new issue, and include this issue number/url for reference. For more information on our processes, please click here

plittlewood-rpt commented 9 months ago

HI @katedeedman please see the spec above for the work being done. In summary, the information is available on the existing endpoints

Hope this helps :)

Pete

github-actions[bot] commented 9 months ago

It looks like you have commented on a closed issue. If your comment relates to a bug or feature request, please open a new issue, and include this issue number/url for reference. For more information on our processes, please click here

reapit / foundations

Endpoint request: Clearing funds in Reapit & Fixflo #8758