reapit / foundations

Foundations platform mono repo
57 stars 21 forks source link

Properties Table - Lettings Agency Missing Custom Agency Types #8759

Closed kmacgregorPR closed 1 year ago

kmacgregorPR commented 1 year ago

Background context Following Custom Agency Types not appearing in analytics schema, please can they be added:

In Jeopardy - For Sale In Jeopardy - Let By Other Agent In Jeopardy - LL Reoccupying In Jeopardy - LL Self Managing In Jeopardy - Other In Jeopardy - Service Issue Lost Management Lost Management - LL Reoccupied Lost Management - Let By Other Agent Lost Management - LL Self Managing Lost Management - Other Lost Management - Service Issue Lost Management - Sold Managed if Let Potential Management - Didn't Go Ahead Potential Management - Switched to LO Retained From In Jeopardy Won Management

Specification

github-actions[bot] commented 1 year ago

This issue has been updated and moved to our ‘Near Term’ column (typically completed within 0 - 4 months). We have assessed the effort required and outlined a technical specification - please take the time to review this detail. When we're ready to schedule the issue, it will be assigned to the relevant board where you can continue to track its progress to completion. For more information on our processes, please click here

github-actions[bot] commented 1 year ago

This issue has been updated and moved to our ‘Mid Term’ column (typically completed within 5 - 8 months). We will assess the effort required and may outline a technical specification. When we're ready to schedule the issue, it will be moved to the ‘Near Term’ column. For more information on our processes, please click here

plittlewood-rpt commented 1 year ago

Hi @kmacgregorPR I've just looked into this and it is working as intended as far as I can tell. Looking at your dataset there's only a single property using one of the custom options (property JES220001 which is a test property) and this is showing as "Managed if Let" correctly in the data warehouse. If you can give me any specific examples where you are seeing this not working please let me know but I think it's just a case of none of your properties are using those custom agency types. Thanks

github-actions[bot] commented 1 year ago

We have recently requested additional information relating to the issue you have raised. Please can you take the time to review this ticket and where applicable, provide the information requested. For more information on our processes, please click here

kmacgregorPR commented 1 year ago

Hi @plittlewood-rpt - thank you for coming back to me. We now have numerous properties in various ones of the status in the original background context, however, in the data tables (via powerquery editor) we are only presented with the options within the screenshot attached. Lettings Agency

plittlewood-rpt commented 1 year ago

Hi @kmacgregorPR the analytics schema will need to refresh before you get the updated data. Can you check in an hour or so as I'd expect it to have updated by then. I think the refresh run starts at half past the hour and it takes about 20 minutes.

github-actions[bot] commented 1 year ago

It looks like you have commented on a closed issue. If your comment relates to a bug or feature request, please open a new issue, and include this issue number/url for reference. For more information on our processes, please click here

plittlewood-rpt commented 1 year ago

Hi @kmacgregorPR I've just checked the PTR system and still can't see any of the custom ones being used. Can you give me some examples of what you've changed? I just want to check we're looking at the same thing! Thanks

kmacgregorPR commented 1 year ago

Hi @plittlewood-rpt - See screen shot of properties with references from Reapit which have had the Lettings Agency changed to some of the custom criteria Capture123

plittlewood-rpt commented 1 year ago

Ahhh this is lettings agency. Thanks for sending that, I'll check over why that might not be being respected properly

plittlewood-rpt commented 1 year ago

I've got a fix pending for this - just waiting for QA so this should be resolved today. Sorry for the confusion, I was convinced I'd read "lettings" somewhere then couldn't see it in the description of the issue (need to check the title next time!!)

plittlewood-rpt commented 1 year ago

This should now be resolved. Thanks

github-actions[bot] commented 1 year ago

It looks like you have commented on a closed issue. If your comment relates to a bug or feature request, please open a new issue, and include this issue number/url for reference. For more information on our processes, please click here

kmacgregorPR commented 1 year ago

Good morning,

I logged the above query on GitHub last week but it has not been assigned to anyone yet, I wondered if I should be submitting this a different way?

Kind regards,

Katherine MacGregor (FARLA) Director 0191 20 90 100 @.**@.>

@.*** www.patrobson.comhttp://www.patrobson.com/ [Join us on Facebook] https://www.facebook.com/pat.robson.35?fref=ts [Follow us on Twitter] https://twitter.com/pat_robson [http://www.patrobson.com/email-signatures/mp-button.png]https://www.patrobson.com/make-a-payment/[http://www.patrobson.com/email-signatures/rr-button.png]https://www.patrobson.com/report-a-repair/

This email is intended solely for the named recipient(s) only. It may contain privileged and/or confidential information. If you are not one of the named recipients, please notify the sender immediately, and destroy this email; you must not copy, distribute or take any action in reliance upon it. Whilst all efforts are made to safeguard inbound and outbound emails, Pat Robson & Co Ltd cannot guarantee that attachments are virus-free or compatible with your systems and does not accept any liability in respect of viruses or computer problems experienced. If you no longer wish to receive emails from Pat Robson & Co Ltd you can unsubscribe from @.***?subject=Please%20Unsubscribe%20Me>. Our privacy policy can be viewed at www.patrobson.com/about-us/cookies-privacyhttps://www.patrobson.com/about-us/cookies-privacy

github-actions[bot] commented 1 year ago

It looks like you have commented on a closed issue. If your comment relates to a bug or feature request, please open a new issue, and include this issue number/url for reference. For more information on our processes, please click here