reapit / foundations

Foundations platform mono repo
56 stars 22 forks source link

Property status changed to Market appraisal #8770

Closed ErnstHavenga001 closed 1 year ago

ErnstHavenga001 commented 1 year ago

We currently report on property status' changed to market appraisal in a given date range. We don't appear to be able to do this at the moment in the data warehouse.

MarketAppraisals" from the Journal entries.

github-actions[bot] commented 1 year ago

Thank you for raising a feature request. Feature requests will be prioritised in accordance with our roadmap, customer and developer priorities. This request will be reviewed in our weekly refinement sessions and assigned to a specific project board or column, depending on the nature of the request and the development work required. For more information on our processes, please click here

plittlewood-rpt commented 1 year ago

Hi @ErnstHavenga001

The existing PROPERTY_SALES_VALUATIONS and PROPERTY_LETTINGS_VALUATIONS model views in the analytics schema are largely based on journal data and should allow you to achieve what you are trying to do. Can you confirm if you've reviewed the data in these tables before we look into this further?

Thanks Pete

github-actions[bot] commented 1 year ago

We have recently requested additional information relating to the issue you have raised. Please can you take the time to review this ticket and where applicable, provide the information requested. For more information on our processes, please click here

ErnstHavenga001 commented 1 year ago

@plittlewood-rpt

Thank you very much for your reply.

If I look at the PROPERTY_SALES_VALUATIONS table, I only see 277 rows under Column VALUATION_DATE for 2023 so far. The Reapit report we are trying to duplicate is producing 4180 rows.

Market_Appraisal Report Market_Appraisals VALUATION_DATE

ErnstHavenga001 commented 1 year ago

@plittlewood-rpt Just wanted to check if you received my comment?

plittlewood-rpt commented 1 year ago

Hi @ErnstHavenga001 altering the valuations view is probably the wrong thing to do here as it's not designed to cater for properties going from a status past Market Appraisal (eg from Under Offer back to Market Appraisal) as this doesn't make sense in the context of the lifetime of a property. We recommend for subsequent sales that an existing property record be duplicated rather than reused, which I suspect is your issue here.

Having said that, I think it would be useful for us to expose a simple view of property status changes so you can report on this how you wish. This view would simply contain the property id, the old status and the new status, along with the date and time of when the change took place. This should give you the best of both worlds.

Does this sound like it will suit your use case? Apologies for the delay coming back to you

ErnstHavenga001 commented 1 year ago

@plittlewood-rpt thank you very much. It does sound like it will suit the use case.

plittlewood-rpt commented 1 year ago

Thanks. I've logged a new ticket, reference above where you can track this.

github-actions[bot] commented 1 year ago

It looks like you have commented on a closed issue. If your comment relates to a bug or feature request, please open a new issue, and include this issue number/url for reference. For more information on our processes, please click here