Rental applicants not receiving bedroomsMin/Max

[robchett]

Describe the bug Creating/Updating an applicant with marketingMode = renting will not save the submitted values for bedroomsMin/Max

To Reproduce Steps to reproduce the behaviour eg:

Create an applicant with this post body:
{
  "active": true,
  "marketingMode": "renting",
  "notes": "Created on the Your Move website.",
  "type": [],
  "bedroomsMin": 1,
  "bedroomsMax": 2,
  "age": [],
  "departmentId": "G",
  "officeIds": [
    "LSH",
    "QYO",
    "NEA",
    "ABB"
  ],
  "negotiatorIds": [
    "YNIB"
  ],
  "locationType": "areas",
  "locationOptions": [
    "DEG"
  ],
  "metadata": {
    "WEBSITE_AREAS": "[{\"title\":\"Hoo Areas\",\"radius\":0,\"reference\":268435839}]",
    "WEBSITE_AUCTION": false,
    "WEBSITE_KEYWORDS": "",
    "WEBSITE_SALE_AGREED": true,
    "WEBSITE_CHAIN_FREE": false,
    "WEBSITE_STUDENT": false
  },
  "renting": {
    "rentFrom": 1,
    "rentTo": 10000,
    "rentFrequency": "monthly",
    "furnishing": []
  },
  "related": [
    {
      "associatedId": "LSH19000003",
      "associatedType": "contact"
    }
  ]
}

Expected behaviour Bedroom values to be stored.

Screenshots N/A

Device (please complete the following information for web issues): N/A

Additional context Updating a sales search to rental leaves the existing bedrooms values but they can't be updated or removed.

Specification

• Project: Reapit.Services.Applicants
• Review customer's department configuration. It is possible that the labels on the room fields are not on our lookup list in the DepartmentNumTitle enum as there is handling for both split single/double bedroom fields and single field for both in the service
• Replicate issue and understand what we need to do to resolve it. Fix with appropriate tests

[github-actions[bot]]

Thank you for taking the time to report a bug. We prioritise bugs depending on the severity and implications, so please ensure that you have provided as much information as possible. If you haven’t already, it really helps us to investigate the bug you have reported if you provide ‘Steps to Replicate’ and any associated screenshots. Please ensure any personal information from the production database is obscured when submitting screenshots. This issue will be reviewed in our weekly refinement sessions and assigned to a specific project board. We may also update the ticket to request additional information, if required. For more information on our processes, please click here

[plittlewood-rpt]

Hi @robchett can you just confirm which dataset this issue has been found in?

[github-actions[bot]]

This issue has been updated and moved to our ‘Near Term’ column (typically completed within 0 - 4 months). We have assessed the effort required and outlined a technical specification - please take the time to review this detail. When we're ready to schedule the issue, it will be assigned to the relevant board where you can continue to track its progress to completion. For more information on our processes, please click here

[RWilcox-Reapit]

Hi @robchett

Can I get the name of the customer you are experiencing this issue with? It works on our Sandbox environment so I'm assuming it's related to the department setup but I'll need to customer details to check.

With this info I'll be able to update the service to handle this edge case.

Thanks, Ryan

[robchett]

Sure, I was testing with YOM.

[RWilcox-Reapit]

Hi @robchett

Based on the clients department setup I'd have expected the extras field 'dOnlyTotalBedsL' to have been set to true like it has been for 'dOnlyTotalBeds'.

I have a fix waiting for this but I'd like to talk to @plittlewood-rpt before pushing this out as it's an edge case which could interrupt the flow for all customer so it may not be until Monday.

Thanks, Ryan

[RWilcox-Reapit]

Hi @robchett Happy to confirm a fix for this has gone in. It was indeed an issue specific to lettings properties and related to the associated departments setup.

Thanks Ryan

[github-actions[bot]]

It looks like you have commented on a closed issue. If your comment relates to a bug or feature request, please open a new issue, and include this issue number/url for reference. For more information on our processes, please click here