reapit / foundations

Foundations platform mono repo
56 stars 22 forks source link

Add CollNote properties in Tenancies #8853

Closed abrahamseni closed 1 year ago

abrahamseni commented 1 year ago

We need to access an extra field in the tenancies like this one in AC

Clipboard - April 6, 2023 4_19 PM

Clipboard - April 6, 2023 4_16 PM

Describe the solution you'd like Add properties CollNote in tenancies.

Specification

github-actions[bot] commented 1 year ago

Thank you for raising a feature request. Feature requests will be prioritised in accordance with our roadmap, customer and developer priorities. This request will be reviewed in our weekly refinement sessions and assigned to a specific project board or column, depending on the nature of the request and the development work required. For more information on our processes, please click here

plittlewood-rpt commented 1 year ago

To discuss with lettings team

plittlewood-rpt commented 1 year ago

Reached out to lettings team to understood intended use of this field so we can evaluate how best to expose and label this property

MatthewGoddard commented 1 year ago

@plittlewood-rpt This is used to records notes and and additional information about the fees that are being charged on a tenancy. In this example, we're going to be storing whether the fee collection is a 6-4-6 month schedule.

plittlewood-rpt commented 1 year ago

HI @MatthewGoddard thanks and I agree, my main concern is that it's not that obvious that it's meant to be a note relating to the fees so it's likely we've got customers out there using it for something different which will look confusing if we add a field called feeNote to the API (or similar)

MatthewGoddard commented 1 year ago

Thanks @plittlewood-rpt Is it Ross or Nicky you're waiting on?

plittlewood-rpt commented 1 year ago

I've had a response and we are in discussions :)

MatthewGoddard commented 1 year ago

I'll butt out then :)

plittlewood-rpt commented 1 year ago

We just need to determine what validation rules to place around this field. AC lets you put whatever you like in that field, but that's bad practice for the API and we should introduce a sensible limit.

johnpenrose commented 1 year ago

@plittlewood-rpt do you have an update on this?

As far as what values will be added to the field, we expect the app to set it to one of the following three values at any given time:

Hopefully this will inform your thinking on the validation rules to apply in the API.

If the field can be made non-editable/disabled in the core software, even better.

HollyJoyPhillips commented 1 year ago

Hi @johnpenrose this is with our Foundations team currently. As soon as we have more information or an update will update the ticket. Thanks.

johnpenrose commented 1 year ago

@HollyJoyPhillips Thanks. What sort of timescales should we expect for a response?

johnpenrose commented 1 year ago

@HollyJoyPhillips if you could let me know by Wednesday mid-afternoon, I'd appreciate it as it is a hot topic on our daily update call/ Thanks

HollyJoyPhillips commented 1 year ago

Hi @johnpenrose this has been approved by the Foundations team and will be moved into our current sprint. Any updates as development progresses will be automatically sent. Thanks.

johnpenrose commented 1 year ago

@HollyJoyPhillips according to Ross, your current sprint ends on Friday 28th. Should we hope for this to be complete by then? Or have we got the wrong dates?

HollyJoyPhillips commented 1 year ago

Hi @johnpenrose that is correct, you can view our sprint dates here: https://github.com/reapit/foundations/projects?type=classic

I shouldn't see a reason for this not to be completed this sprint.