search

reapit / foundations

Foundations platform mono repo
56 stars 22 forks source link

Setting client account in order to use POST/Transactions/supplierInvoice endpoint #9642

Closed katedeedman closed 1 year ago

katedeedman commented 1 year ago

Hey Reapit,

We have a shared client hoping to use the POST/Transactions/supplierInvoice endpoint to sync invoices from Fixflo into Reapit. When looking at their RPS, we've noticed that they don't have the Client Account field within the Landlord Financial Details modal (screenshot below).

image (57)

When we built the new configuration using the new endpoint, we did face a few errors in testing when this field wasn't set. So I wanted to confirm:

Many thanks in advance!

Kate (Lead Product Manager at Fixflo)

AshDeeming commented 1 year ago

Hi @katedeedman This functionality is only enabled for client using our Client Accounts solution.

katedeedman commented 1 year ago

Hi Ash,

Thanks for letting me know.

And does it need to be set in order to use the POST/Transactions/supplierInvoice endpoint?

Best,

Kate

On Tue, 15 Aug 2023 at 15:28, Ash @.***> wrote:

Hi @katedeedman https://github.com/katedeedman This functionality is only enabled for client using our Client Accounts solution.

— Reply to this email directly, view it on GitHub https://github.com/reapit/foundations/issues/9642#issuecomment-1679026110, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4CMXE6H3E4ZPIIXMIFXULTXVOBP3ANCNFSM6AAAAAA3Q6I5AY . You are receiving this because you were mentioned.Message ID: @.***>

katedeedman commented 1 year ago

Hello!

Just chasing up this one. If someone could let me know if this means the client can't use the POST/Transactions/supplierInvoice endpoint, that would be great.

Thanks!

-Kate

On Tue, 15 Aug 2023 at 15:30, Kate Deedman @.***> wrote:

Hi Ash,

Thanks for letting me know.

And does it need to be set in order to use the POST/Transactions/supplierInvoice endpoint?

Best,

Kate

On Tue, 15 Aug 2023 at 15:28, Ash @.***> wrote:

Hi @katedeedman https://github.com/katedeedman This functionality is only enabled for client using our Client Accounts solution.

— Reply to this email directly, view it on GitHub https://github.com/reapit/foundations/issues/9642#issuecomment-1679026110, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4CMXE6H3E4ZPIIXMIFXULTXVOBP3ANCNFSM6AAAAAA3Q6I5AY . You are receiving this because you were mentioned.Message ID: @.***>

AshDeeming commented 1 year ago

Hi @katedeedman If a client is not setup/enabled for Client Accounts within AgencyCloud - They will not have nominal accounts setup & therefore will be invalid.

Please refer to the following ticket for further validation information; https://github.com/reapit/foundations/issues/7764

katedeedman commented 1 year ago

Thanks for confirming, Ash!

On Tue, 22 Aug 2023 at 13:45, Ash @.***> wrote:

Hi @katedeedman https://github.com/katedeedman If a client is not setup/enabled for Client Accounts within AgencyCloud - They will not have nominal accounts setup & therefore will be invalid.

— Reply to this email directly, view it on GitHub https://github.com/reapit/foundations/issues/9642#issuecomment-1688115400, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4CMXE54D4ZWFTP3XVVGQX3XWSSUZANCNFSM6AAAAAA3Q6I5AY . You are receiving this because you were mentioned.Message ID: @.***>

HollyJoyPhillips commented 1 year ago

@plittlewood-rpt to verify state with the Client Accounts team

plittlewood-rpt commented 1 year ago

HI @katedeedman

I've checked in with our client accounts team and the option to set the account only shows if the customer has more than one primary client account configured in their system which is why the customer concerned can't see it. That said, it does look like we've got some handling for this scenario in the transactions API so I'll look into why this isn't working as we'd expect ASAP and come back to you.

Thanks

plittlewood-rpt commented 1 year ago

HI @katedeedman looking at this, and re-reading the above, you've not mentioned if you've actually had an error or not. There is handling in the API for the scenario where there's only a single account set so you should find you can post supplier invoices without an issue. Can you confirm if you've actually had a problem here (or if this was just logged out of curiosity to confirm the behaviour?). If the former, are you able to provide an example as I've run through the API endpoint code against their system and it's behaving as I'd expect.

katedeedman commented 1 year ago

Hey Pete,

This was logged just out of curiosity when the client raised that they don't have that field. We wanted to double check after the discussion on this ticket - https://github.com/reapit/foundations/issues/9008 https://github.com/reapit/foundations/issues/9008

I'll ask one of our devs to have a go and let you know how we get on!

-Kate

On Wed, 6 Sept 2023 at 16:32, Pete Littlewood @.***> wrote:

HI @katedeedman https://github.com/katedeedman looking at this, and re-reading the above, you've not mentioned if you've actually had an error or not. There is handling in the API for the scenario where there's only a single account set so you should find you can post supplier invoices without an issue. Can you confirm if you've actually had a problem here (or if this was just logged out of curiosity to confirm the behaviour?). If the former, are you able to provide an example as I've run through the API endpoint code against their system and it's behaving as I'd expect.

— Reply to this email directly, view it on GitHub https://github.com/reapit/foundations/issues/9642#issuecomment-1708620179, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4CMXE6WGAIO4TF54WZCETTXZCJSRANCNFSM6AAAAAA3Q6I5AY . You are receiving this because you were mentioned.Message ID: @.***>

plittlewood-rpt commented 1 year ago

Ah brill - sorry I misunderstood what was going on with this then. Yes you should be fine to proceed. Do you want me to leave this open for a day or two to give you chance to confirm back to me that all is well? For reference we do the following to try and set the client account:

plittlewood-rpt commented 1 year ago

Pending 3rd party feedback

katedeedman commented 1 year ago

Thank you! If you wouldn't mind keeping it open for another day or two, that would be great. Just in case we have any follow up questions.

I've asked one of our devs to look at it tomorrow.

-Kate

On Wed, 6 Sept 2023 at 16:53, Pete Littlewood @.***> wrote:

Pending 3rd party feedback

— Reply to this email directly, view it on GitHub https://github.com/reapit/foundations/issues/9642#issuecomment-1708653997, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4CMXEZRGIEL5JXXDWEDQLTXZCL6TANCNFSM6AAAAAA3Q6I5AY . You are receiving this because you were mentioned.Message ID: @.***>

plittlewood-rpt commented 1 year ago

HI @katedeedman are we good to close this down?

katedeedman commented 1 year ago

Hi Pete,

I caught up with one of our developers last night about this. I wondered if you could point me in the direction of where the single primary account is configured in our sandbox?

Thanks!

Kate

On Tue, 12 Sept 2023 at 08:41, Pete Littlewood @.***> wrote:

HI @katedeedman https://github.com/katedeedman are we good to close this down?

— Reply to this email directly, view it on GitHub https://github.com/reapit/foundations/issues/9642#issuecomment-1715170075, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4CMXEYHAZMQXSDNBTQL7ZTX2AGZ5ANCNFSM6AAAAAA3Q6I5AY . You are receiving this because you were mentioned.Message ID: @.***>

plittlewood-rpt commented 1 year ago

Hi Kate

There's actually 2 primary accounts configured in the Developer Edition. You can see them if you open up a Landlord and click the little pencil icon next to the Financial header

image

Hope this helps - let me know if i've misunderstood your question.

Thanks Pete

katedeedman commented 1 year ago

Hello!

Sorry, I wondered where it's set if they don't have that Client Account field?

Our Sandbox set up reflects your screenshots but struggling to see how it's set for those users that don't have that field.

Thanks!

-Kate

On Tue, 12 Sept 2023 at 11:02, Pete Littlewood @.***> wrote:

Hi Kate

There's actually 2 primary accounts configured in the Developer Edition. You can see them if you open up a Landlord and click the little pencil icon next to the Financial header

[image: image] https://user-images.githubusercontent.com/30798627/267292247-ad857084-b2a7-4c37-827b-d4de11ae6ec5.png

Hope this helps - let me know if i've misunderstood your question.

Thanks Pete

— Reply to this email directly, view it on GitHub https://github.com/reapit/foundations/issues/9642#issuecomment-1715404331, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4CMXE2EVYNA2UCXPNQQBV3X2AXKFANCNFSM6AAAAAA3Q6I5AY . You are receiving this because you were mentioned.Message ID: @.***>

plittlewood-rpt commented 1 year ago

Hi Kate

Sorry I think I misunderstood possibly. When only a single primary account is configured, the system infers it's use rather than explicitly storing it. The API does the same thing and explicitly checks how many primary accounts are configured when storing a supplier invoice in the database. If there's only one, we use it (as this is what AgencyCloud does) and it doesn't require setting against the landlord at all. If there's more than one, that's where we need the branch configure the correct primary account against the landlord, and so they see the additional option on the screen shown above.

Does that answer the question a bit better? Let me know if not :)

Thanks

plittlewood-rpt commented 1 year ago

Hi Kate - I'll close this item down for now as I think you should have all you need. Just let me know if not. Cheers

github-actions[bot] commented 1 year ago

It looks like you have commented on a closed issue. If your comment relates to a bug or feature request, please open a new issue, and include this issue number/url for reference. For more information on our processes, please click here