several property's financial fields value on AC not exposed on the property service

reapit / foundations

Foundations platform mono repo

57 stars 21 forks source link

several property's financial fields value on AC not exposed on the property service #9701

Open ss-dimasm opened 10 months ago

ss-dimasm commented 10 months ago

Is your feature request related to a problem? Please describe. We have a requirements to GET and PATCH several fields on property's financial section, looks like these fields on AC haven't exposed on the property model. Can we add these to the current API spec on property? thanks. Let me know if you need more details

Sales Property

Market Appraisal By
Market Appraisal From
Market Appraisal To

UI placement on AC (Sales)

Let Property

Agency
Inspected By

UI placement on AC (Let)

Describe the solution you'd like Could you please to add those fields to the current model, so we could access and update it via API.

FYI @craigforrest @saimonsaikat

github-actions[bot] commented 10 months ago

Thank you for raising a feature request. Feature requests will be prioritised in accordance with our roadmap, customer and developer priorities. This request will be reviewed in our weekly refinement sessions and assigned to a specific project board or column, depending on the nature of the request and the development work required. For more information on our processes, please click here

plittlewood-rpt commented 10 months ago

To research further - this doesn't look like the standard screen

AshDeeming commented 10 months ago

Hi @ss-dimasm Please could you confirm which build/database the above screenshots are from please?

craigforrest commented 10 months ago

Screenshots are from the Reapit Online Demo (ROD) build

The screenshots are from a property's Financial screen for sales:

and the rent/fee details for lettings:

Opening the screen in the build does not trigger a DLL which suggests a custom screen is not being used, and the only enabled config setting that I can see which would affect the screen is this:

craigforrest commented 9 months ago

@AshDeeming Let me know if this needs any further discussion

plittlewood-rpt commented 9 months ago

@craigforrest I'm going to split this up into multiple tickets as there's a lot been request here. I'll link the tickets once I've done it.

github-actions[bot] commented 9 months ago

This issue has been reviewed and is too big to be handled in a single issue and requires the need to be broken down by our development team. We will add the associated/dependent issues to this ticket when available. The individual tickets will then be review in our weekly refinement sessions. For more information on our processes, please click here

plittlewood-rpt commented 6 months ago

Selling Agency already available from GET /properties/ in PropertyModel.selling.agencyId (I don't recommend using agency because it doesn't support customisations

craigforrest commented 5 months ago

fyi @ss-dimasm

ss-dimasm commented 5 months ago

Thanks @plittlewood-rpt , we have include the selling agency field based on selling.agencyId instead selling.agency

plittlewood-rpt commented 3 months ago

@craigforrest the first screenshots from SS are of the Australia features. Can you just outline what's actually required here please for clarity? I would challenge the MA Date, Market Appraisal by and Instructed Date as these should really be inferred from appointments and journal entries and I'm of the opinion that this should be the way it should work in the CRM as well. @rpt-sabmatharu do you have any thoughts or opinions on this?