reapp / reapp-ui

Amazing cross platform UI's with React and JavaScript
https://reapp.io
MIT License
257 stars 47 forks source link

Fix misaligned top border on ListItem after element #38

Closed mbrgm closed 9 years ago

mbrgm commented 9 years ago

Due to the nature of the box model, the specified border on the after element does not line up with the rest of the ListItem's top border. I used the flex model's justifyContent property to center the after content vertically and turned the remaining margin into a padding property.

mbrgm commented 9 years ago

This is an example from the kitchen sink app in Chrome. You can see the top border of the after element not properly lining up.

bildschirmfoto 2015-03-12 um 00 50 53

natew commented 9 years ago

Thanks a lot for this. I had changed this a while back and noticed the bug but never got around to fixing it.