search

reapp / reapp-ui

Amazing cross platform UI's with React and JavaScript
https://reapp.io
MIT License
257 stars 47 forks source link

Minor style bug: left border incorrectly showing on alert OK button #7

Closed adamschwartz closed 9 years ago

adamschwartz commented 9 years ago

screen shot 2015-02-10 at 1 43 03 pm

screen shot 2015-02-10 at 1 45 09 pm

adamschwartz commented 9 years ago

Looks adding borderLeft: "none" to https://github.com/reapp/reapp-ui/blob/master/themes/ios/styles/ModalButton.js would resolve the issue, although that may be needed for multiple button support? In that case maybe you can apply it only to :first-child somehow.

natew commented 9 years ago

Yep, thank you. We actually had firstChild but in a very recent change we've broken it. We moved modals to use ButtonGroup, which typically actually did the "reverse", so we just need to make ModalButtonGroup or modify ButtonGroup to support it again.

adamschwartz commented 9 years ago

Cool. Yeah in left-to-right languages I generally place in-between borders/margins on the bottom and right and cancel them on last children.

natew commented 9 years ago

This should be fixed in 0.8.20, let me know if it works for ya.

adamschwartz commented 9 years ago

Looks fixed on http://kitchen.reapp.io/buttons. Thanks!