search

reason-native-web / morph

A webframework for Reason and OCaml
https://reason-native-web.github.io/morph/
MIT License
139 stars 7 forks source link

Move GraphiQL.re from graphql template to morph-server-graphql #24

Open baransu opened 4 years ago

baransu commented 4 years ago

It would be great to provide ~graphiql: bool option to Morph_graphql_server.make or provide something like Morph.Response.text(Library.GraphiQL.html, Morph.Response.empty) available from Morph_graphql_server module

/ cc @cem2ran

cem2ran commented 4 years ago

Would be great!

Some more (powerful) options:

I added GraphiQL as it was the easiest and quickest, but worth considering whether one should allow this to be a bit more configurable. Should it just be a url or should it just be yet another middleware? @ulrikstrid

baransu commented 4 years ago

Another option is to point users to standalone GraphQL clients like:

instead of providing GraphiQL middleware.

I'm personally using Altair and none of my projects expose GraphiQL.

ulrikstrid commented 4 years ago

I think that this is a documentation problem basically. I like that graphiql (or any derivative) is provided in the pesy template because it's really powerful to have there. But I'm not sure we want to integrate it into the the library. I'm not against it, I'm just not sure we want to do it since it can feel like "lock in" to that particular implementation. We also have to keep it up to date.