reason-seoul / rescript-collection

Fast and efficient, persistent immutable collection for JS written in 100% ReScript!
https://rescript-collection.pages.dev
MIT License
56 stars 4 forks source link

add cache props for ...init, last pattern matching #60

Closed cometkim closed 1 year ago

cometkim commented 1 year ago

This enables vec{...init, last} like pattern matching

The problem with this implementation is init introduce self-referencing which makes it too deep to serialize. As the result, existing tests are failed because of stackoverflow while checking the equality

We need a smarter way to make init more efficient or an alternative structure.

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: f1ad495a845def43a14fd613c8615a5566b524b9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

cloudflare-pages[bot] commented 1 year ago

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f1ad495
Status: ✅  Deploy successful!
Preview URL: https://bceb3f6b.rescript-collection.pages.dev
Branch Preview URL: https://match-props.rescript-collection.pages.dev

View logs

cometkim commented 1 year ago

Ok we dont need this