reasonml-community / belt

MIT License
49 stars 1 forks source link

`mapWithIndex` and `keepWithIndex` are not consistent #36

Open prestontw opened 3 years ago

prestontw commented 3 years ago

Hello! I'm starting out with reasonml. I'm confused why mapWithIndex and keepWithIndex have different parameter orders for their function parameter: mapWithIndex takes (int, 'a) => ... while keepWithIndex takes ('a, int) => ....

For comparison, Tablecloth's mapWithIndex has a consistent ordering with its filterWithIndex: f:(int -> 'a -> ...); Rust dodges this with an enumerate method for iterators which can then be filtered or mapped as necessary.