reasonml-community / bs-express

Express bindings in Reason
MIT License
210 stars 60 forks source link

Websockets example #49

Closed graforlock closed 4 years ago

graforlock commented 6 years ago

Can we add bs-socket.io to the example?

It is unclear to me how to make them work together.

ncthbrt commented 6 years ago

How would you make them work together in JavaScript?

On Wed, Aug 29, 2018 at 3:25 PM Maciej Sitko notifications@github.com wrote:

Can we add bs-socket.io to the example?

It is unclear to me how to make them work together.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/reasonml-community/bs-express/issues/49, or mute the thread https://github.com/notifications/unsubscribe-auth/AISSWSRXpik1cm398IYnApToREvi5OAIks5uVpYxgaJpZM4WRiYG .

graforlock commented 6 years ago

One of the examples is here: https://github.com/reasonml-community/bs-socket.io/blob/master/example/ExampleServer.re

But relies on different, closer to original, express binding. Requires to define http binding as its not exported by default in neither bs-node nor bs-express.

ncthbrt commented 6 years ago

Will only get an opportunity to look at this next week @graforlock