search

reasonml-community / bs-express

Express bindings in Reason
MIT License
210 stars 60 forks source link

#76 #85

Closed LaMavia closed 4 years ago

LaMavia commented 4 years ago

  1. 76

  2. explicitly define external function names
  3. reorder certain definitions within the interface to match the order in the declaration file
  4. update bs-platform@8.2.0
ncthbrt commented 4 years ago

@DerivedMate Thanks for the PR. Assume you've tested that everything still is working?

ncthbrt commented 4 years ago

Are we going to upgrade to use *.res files?

LaMavia commented 4 years ago

@DerivedMate Thanks for the PR. Assume you've tested that everything still is working?

I've run the tests, and they've all passed

Are we going to upgrade to use *.res files?

There appear to be some syntax differences, so it'd take a bit of time to rewrite. I can have a go at it at the weekend, though

ncthbrt commented 4 years ago

Sounds good to me.

LaMavia commented 4 years ago

Nvm, according to the docs it'd be as simple as running node_modules/.bin/bsc -format MyFile.re > MyFile.res