reasonml-community / bs-express

Express bindings in Reason
MIT License
210 stars 60 forks source link

Fix a bug in the static middleware setHeaders type signature #93

Closed samueljseay closed 2 years ago

samueljseay commented 3 years ago

Today I was trying to customise the setHeaders option of the Express static middleware and noticed that the type signature in bs-express expects Request.t, but it should be Response.t. See the docs.

I couldn't get the tests working locally. I realize this project is not very actively maintained but if anyone could assist with that I'd be happy to put the effort in.

Thanks.