search

reasonml-community / reason-apollo-hooks

Deprecated in favor of https://github.com/reasonml-community/graphql-ppx
https://reasonml-community.github.io/reason-apollo-hooks/
MIT License
137 stars 28 forks source link

Apollo Client 3 branch? #121

Open jeddeloh opened 4 years ago

jeddeloh commented 4 years ago

I wonder if #117 presents an opportunity to cut an apollo-client-3 branch and do some restructuring to better match types (and possibly modules) in @apollo/client? I’d be happy to help with this.

jfrolich commented 4 years ago

Yes that would be great!

fakenickels commented 4 years ago

that would be wonderful! @jeddeloh

jeddeloh commented 4 years ago

Great. Unless someone wants it first, I'll plan on starting with useQuery and following it to the end, sticking as close as possible to @apollo/client and get a PR up for discussion. Hopefully that will be sufficient to see if this is a path we actually want to go down :)

jfrolich commented 4 years ago

That would be amazing @jeddeloh. FYI: I am actually exploring an API where we could extend the Query/Mutation/Subscription with a use function, so we don't need definition anymore. I will experiment a bit more to see if we make this the default for graphql-ppx 1.0. But don't worry it is fairly easy to adapt to this when we have the old API.

jeddeloh commented 4 years ago

@fakenickels @jfrolich #122 is up for discussion.

@jfrolich, I see now I should have been paying attention to the graphql channel on discord! Seriously, this graphql-ppx 1.0 is like the gift you desperately wished for but didn't expect, and now that you've received it, it's even better than you could have imagined. 🎅 I'll take a look at your proposal.