search

reasonml-community / reason-apollo-hooks

Deprecated in favor of https://github.com/reasonml-community/graphql-ppx
https://reasonml-community.github.io/reason-apollo-hooks/
MIT License
137 stars 28 forks source link

Upgrade reason-apollo to 0.20 #126

Closed mbirkegaard closed 4 years ago

mbirkegaard commented 4 years ago

I may have been misunderstanding something, but it seems that master can't compile without upgrading reason-apollo to 0.20 so I thought I'd do that.

  159 │ let toQueryObj = result =>
  160 │   ApolloClient.{
  161 │     query: ApolloClient.gql(. result##query),
  162 │     variables: result##variables,
  163 │   };

  The record field query can't be found.
fakenickels commented 4 years ago

hmm good catch, it should be using the latest one with the new BS record support

fakenickels commented 4 years ago

hmm good catch, it should be using the latest one with the new BS record support. Can you update the demo as well?

mbirkegaard commented 4 years ago

Can you update the demo as well?

Sure! I'm not sure which demo you mean though? AFAICT it's not being used in the README nor in the persons example.

mbirkegaard commented 4 years ago

@fakenickels Which demo are you referring to?

fakenickels commented 4 years ago

Aah sorry! Thought it was still being used