search

reasonml-community / reason-apollo-hooks

Deprecated in favor of https://github.com/reasonml-community/graphql-ppx
https://reasonml-community.github.io/reason-apollo-hooks/
MIT License
137 stars 28 forks source link

Purpose of Called in variant result #46

Closed lukashambsch closed 4 years ago

lukashambsch commented 4 years ago

I was looking at adding NotCalled to the variant type & noticed the Called option on that type already.

What is the use case for the Called option? Don't the Loading, Error, Data options cover the use cases when Called would be used?

I'm also trying to make sure there is a use case for NotCalled before adding it.

fakenickels commented 4 years ago

Indeed it does not make sense! I can't remember why it is there

mbirkegaard commented 4 years ago

This was fixed by #60, right?

fakenickels commented 4 years ago

Yes! Thanks for reminding