search

reasonml-community / reason-apollo-hooks

Deprecated in favor of https://github.com/reasonml-community/graphql-ppx
https://reasonml-community.github.io/reason-apollo-hooks/
MIT License
137 stars 28 forks source link

Uses error types from ReasonApollo #87

Closed mbirkegaard closed 4 years ago

mbirkegaard commented 4 years ago

This PR simply copies the error types from reason-apollo into ApolloHooksTypes.re. I could have just used ReasonApolloTypes.apolloError, but thought it best to not create another dependency between reason-apollo-hooks and reason-apollo.

I decided against converting the deeper js types to reason, but let me know if that's preferred and I'll update this.

fakenickels commented 4 years ago

Looks ok to me! Part of separating from reason-apollo

mbirkegaard commented 4 years ago

Can this be merged?

medson10 commented 4 years ago

Can this be merged?

Yes, merge please

fakenickels commented 4 years ago

We'll be released soon