reasonml-community / reason-apollo-hooks

Deprecated in favor of https://github.com/reasonml-community/graphql-ppx
https://reasonml-community.github.io/reason-apollo-hooks/
MIT License
137 stars 28 forks source link

Subscribe to more #91

Closed Yakimych closed 4 years ago

Yakimych commented 4 years ago

This PR is a continuation of the work done by @MargaretKrutikova on subscribeToMore. I've added examples to demonstrate the functionality and rearranged the code a bit. I am also planning to add more examples after migrating from Graphcool to Hasura: https://github.com/Astrocoders/reason-apollo-hooks/issues/90

There are a few questions I am not sure about:

fakenickels commented 4 years ago

Hey there! Sorry about the delay, I was in vacation these past 2 weeks. Everything is looking good to me! We just have a merge conflict there to solve looks like

Yakimych commented 4 years ago

@fakenickels No worries - thanks for reviewing. I've rebased the branch on master and resolved the conflicts. Nice to see that startPolling and stopPolling has landed in master!

fakenickels commented 4 years ago

@all-contributors update @Yakimych to add code

allcontributors[bot] commented 4 years ago

@fakenickels

I've put up a pull request to add @code! :tada:

fakenickels commented 4 years ago

@all-contributors update @Yakimych for code

allcontributors[bot] commented 4 years ago

@fakenickels

I could not determine your intention.

Basic usage: @all-contributors please add @someone for code, doc and infra

For other usages see the documentation

fakenickels commented 4 years ago

@all-contributors add @Yakimych for code, bugs

allcontributors[bot] commented 4 years ago

@fakenickels

I've put up a pull request to add @Yakimych! :tada:

fakenickels commented 4 years ago

As we are upgrading to BS7 I released this under a major version, now it is available as v5.0.0.

Thanks a lot @Yakimych !

fakenickels commented 4 years ago

We had updated the lib itself but not the demo as you had noticed 🤔