Closed mbirkegaard closed 4 years ago
Will review soon
@fakenickels When it comes time to release this, can you do a release candidate first? We're starting to migrate a lot of users to our Reason platform so there's a chance that we'll discover more bugs. It would be annoying to keep making braking changes to major releases as we fix them.
Edit: Tagged the wrong person (sorry @baransu)
Of course! We have been churning a lot of the last changes
Sorry about the delay to merge, we have been a bit busy these past few weeks
Sorry about the delay to merge, we have been a bit busy these past few weeks
No worries at all! It's OSS! Noone is paying, so noone is owed anything ;)
🙏 @mbirkegaard are you on ReasonML Discord server? If so what's your handle there?
I'm am, though I only pop in occasionally. My handle is FreddieFreeloader
All credit to @Emilios1995. I'm just the one putting up the PR.
This fixes the type of the promise returned by
mutate
.On the ts side,
useMutation
returns a tuple with this definition:where
The previous reason types assumed that
mutate
returnedPromise<MutationResult<TData>>
instead ofPromise<ExecutionResult<TData>>
This is a breaking change. Particularly annoying after #89.