This PR adds OSL configuration UI. Few issues to resolve.
bsb integration
One thing that doesn't work yet is bsb integration. Here's what I see w/ different diagnostics.tools config:
["merlin"]
Diagnostics is reported as I type. Errors persist after I hit Save.
["merlin", "bsb"]
Diagnostics is reported as I type. Errors disappear after I hit Save, bsb is not triggered.
["bsb"]
Nothing happens on change (as expected) and bsb is not triggered on save.
Configurable toolchain
This thing never worked b/c readFileConf always returns empty string (b/c projectPath is not passed). Anyway, w/ this change I don't think it makes sense to keep it as-is (even fixed). We can convert it into configuration file based on OSL configuration format and pick it from either package.json or ide-reason.json. Thoughts?
zaaack
commented
6 years ago
This PR adds OSL configuration UI. Few issues to resolve.
bsbintegration One thing that doesn't work yet isbsbintegration. Here's what I see w/ differentdiagnostics.toolsconfig:["merlin"]Diagnostics is reported as I type. Errors persist after I hit Save.["merlin", "bsb"]Diagnostics is reported as I type. Errors disappear after I hit Save,bsbis not triggered.["bsb"]Nothing happens on change (as expected) andbsbis not triggered on save.Configurable toolchain This thing never worked b/c
readFileConfalways returns empty string (b/cprojectPathis not passed). Anyway, w/ this change I don't think it makes sense to keep it as-is (even fixed). We can convert it into configuration file based on OSL configuration format and pick it from eitherpackage.jsonoride-reason.json. Thoughts?