search

reasonml-editor / atom-ide-reason

ReasonML/OCaml language support for Atom-IDE, using ocaml-language-server under the hood.
MIT License
34 stars 8 forks source link

Bump deps #22

Closed alex35mil closed 6 years ago

alex35mil commented 6 years ago

@zaaack I bumped deps (incl. ocaml-language-server) and tried to change few random things in my codebase: I haven't seen broken pipe error yet, hope it's gone.

Another thing I wanted to discuss: should we remove ^ in deps versions in package.json? E.g.

"ocaml-language-server": "^1.0.34" -> "ocaml-language-server": "1.0.34"

W/ ^, every user gets latest version of dependency and we can face situation when we have previous version of package but another user (that installed ide-reason just now) got latest version of some dependency which introduced regression. Or other weird works-on-my-machine case.

P.S. Sorry for noise in commits, there were some merge conflicts in my fork. But it seems actual changes are only in latest commit Bump deps.

zaaack commented 6 years ago

@alexfedoseev I would prefer to remove ^, just as you say, it's easier to track issues. I'll keep quick response to new issues, so I think we do not really need the newest patch version.

alex35mil commented 6 years ago

@zaaack Alright, lemme get rid of them.

alex35mil commented 6 years ago

@zaaack Done.

zaaack commented 6 years ago

@alexfedoseev Thanks a lot!