search

reasonml-editor / atom-ide-reason

ReasonML/OCaml language support for Atom-IDE, using ocaml-language-server under the hood.
MIT License
33 stars 8 forks source link

Types inside of functors are difficult to read #26

Open johnhaley81 opened 6 years ago

johnhaley81 commented 6 years ago

👋

I don't know if this is the correct repo to write this up in.

When using functors, any types that inside of that functor don't give their types on mouse-over. They give the entire functor's type which could be very large and difficult to read.

Ex: image

alex35mil commented 6 years ago

Let’s see how it works w/ RLS when #27 will be merged.

RawToast commented 6 years ago

This is interesting as I raised a similar issue with VsCode and it is probably an issue with an underlying library.

I would assume if this is fixed here, the same fix may work for VsCode (or I'll start using Atom!)

alex35mil commented 6 years ago

@RawToast We didn't do anything special about it, just updated from ocaml-language-server to reason-language-server. If you're using OLS in VSCode you can change extension you're using and you'll get the same result.

johnhaley81 commented 6 years ago

I haven't seen an improvement with RLS :(

alex35mil commented 6 years ago

Then RLS repo is a more proper place for this issue, all clients just display data from language server.