search

reasonml-editor / vscode-reasonml

OCaml & Reason support for Visual Studio Code
Apache License 2.0
491 stars 62 forks source link

Fix percent sign attributes with no payload #283

Closed trishume closed 5 years ago

trishume commented 5 years ago

Some PPX macros like https://github.com/janestreet/ppx_here are used without any contents like [%here], in this case the current version of the extension gets stuck and doesn't exit when it sees the right square bracket, this PR fixes it.

ghost commented 5 years ago

Thanks!

trishume commented 5 years ago

@freebroccolo If you haven't already would you mind publishing an update to the extension with this fix? The way I have things set up at work it's way easier if I can just update the extension.

Also I may be willing to help very casually maintain this plugin and review PRs if you'd like. I'm planning on attempting to use it at work. You can check out my Github and website to appraise me as an open source citizen.

ghost commented 5 years ago

@trishume unfortunately I don't have the bandwidth to do proper testing for another release right now and I'm reluctant to publish something and then have it be broken for a lot of people.

It's a slight inconvenience to maintain your own local version but doable. Another option would be to maintain your own fork of this which you can then publish and install as usual.

I appreciate the offer to help maintain the extension but at this point I don't have the bandwidth even to casually help with things like preparing releases behind the scenes. It would probably be better to check out the other extension the Reason folks are using now instead.