reasonml-old / bs-node

Node bindings for BuckleScript
78 stars 17 forks source link

How to contribute? #13

Closed francjpd closed 6 years ago

francjpd commented 6 years ago

Hello

Is there any way to contribute? there no contributing.md on how to do so... Thanks!

Btw. I tried adding some functionality then running the npm build script. After it succeded "building" it i used the command:

npm link to test it locally but it did not work :(

That's why i am asking for an contributing.md. I might be doing something wrong!

Cheers.

ncthbrt commented 6 years ago

Did you manage to get the file in the test folder to run @francjpd?

francjpd commented 6 years ago

Hello @ncthbrt

Hmm i don't know what you exactly mean... Hmmm i will try to provide more detail.

I have a small app that uses reasonml-community/bs-node in my dependencies. So i forked the repo and decided to add a functionality to the library (which i eventually plan to create a pull request to merge it with this repo )... After i added the functionality at my forked library i did run the following commands:

npm run build npm link

I went to my app's project and executed the following command.

npm link bs-node

I did not run any test since i wanted to try my functionality without doing any important test which i plan to do once i manage to get my functionality to work on my small project :)

ncthbrt commented 6 years ago

Did you add bs-node to your reasonml (bsconfig.json) dependencies file? Reason needs to know about the library so it can be built.

francjpd commented 6 years ago

I might have done it the wrong way ... ill recheck it and let you know ASAP (am at work). but if i am not mistaken:

I have bs-node on my dependencies at package.json and bs-dependencies at bsconfig.json .

Thank you for your time.

ncthbrt commented 6 years ago

Apologies, difficult to diagnose the problem as I typically develop new features for the library using the test file, which doesn't require npm linking

francjpd commented 6 years ago

Done it was related to the namespace=true at the bsconfig.json.... I had to explicitly say BsNode. https://bucklescript.github.io/docs/en/build-configuration.html