Nested Folders Native Backend

reasonml-old / rebel

122 stars 16 forks source link

Nested Folders Native Backend #48

Closed vramana closed 7 years ago

vramana commented 7 years ago

[x] Nested Folder src
[x] Nested Folder node_modules
[x] Refactoring & Comments

vramana commented 7 years ago

@chenglou @jordwalke Is it okay to allow only camelCase and PascelCase names for folders inside src/ for now?

vramana commented 7 years ago

Only kebab-case sub-folders are not allowed now. We can resolve that at a later point.

chenglou commented 7 years ago

This will have to go through @jordwalke as it breaks the Rebel spec of ignoring folder names.

vramana commented 7 years ago

Third-party libraries names of the format foo-bar are transformed into FooBar when used as module name (source file names aren't allowed to have kebab-case).

Since we already disallow kebab-case source files. I think it's fine to disallow on the sub-folders also. I don't think this is a breaking change.

chenglou commented 7 years ago

Great stuff! Now we have recursive src =D

Thanks again!