search

reasonml / ReasonNativeProject

Reason native compilation starter project
MIT License
203 stars 45 forks source link

Jbuilder #32

Closed jaredly closed 7 years ago

jaredly commented 7 years ago

continuation of #30

jaredly commented 7 years ago

I think it leads to less confusion. Might has well have the directories have the same names as the compiled artifacts

jaredly commented 7 years ago

tbh I'd rather capitalize Internal_lib and all of the source files M1.re etc.

jordwalke commented 7 years ago

@jaredly If you prefer it, you can capitalize the files if you like - we could also setup a case sensitive travis build to let us know if that introduces any issues.

Regardless of if the package name is reason-native-project or reason-native-project, I think when it comes to actual code, the underscores are a little less familiar to JS developers. Is there a way to allow people to consume the result of this as ReasonNativeProject.InnerModules? Or is there some limitation in jBuilder?

jaredly commented 7 years ago

oh for sure! I was just converting from kebab to underscores, I'm totally fine with camel

jordwalke commented 7 years ago

Nice! I'll just wait until the CI passes then merge!

jordwalke commented 7 years ago

Happy to merge, but CI is not happy for some reason. Do you know what's up?

jaredly commented 7 years ago

oh funny, looks like there some duplication between travis.yml and test-with-version

jordwalke commented 7 years ago

Very good! Thank you @jaredly. Thank you @rgrinberg! This is a massive improvement.

kennetpostigo commented 7 years ago

Does the readme of the project need to be updated with the move to JBuilder?

jordwalke commented 7 years ago

yes! Do you feel like helping to document it? ( @jaredly might have suggestions for going beyond basic instructions but feel free to send PRs for ideas )