reasonml / ReasonNativeProject

Reason native compilation starter project
MIT License
203 stars 45 forks source link

Building the project without esy fails #39

Open slightlytyler opened 6 years ago

slightlytyler commented 6 years ago
Error: Library "sub" is private, it cannot be a dependency of a public library.
You need to give "sub" a public name.
chu-rh commented 6 years ago

Any update on this?

satansdeer commented 6 years ago

Yeah, stumbled upon same issue. Not able to build without esy.

satansdeer commented 6 years ago

Actually same issue with esy

# Unformatted Error Output:
# File "lib/jbuild", line 7, characters 17-20:
# Error: Library "sub" is private, it cannot be a dependency of a public library.
satansdeer commented 6 years ago

Good news everyone, i've got a PR fixing this: https://github.com/reasonml/ReasonNativeProject/pull/43