Closed satansdeer closed 6 years ago
The CI is failing. If you get it passing, I'll merge this.
I've never heard of the include_subdirs unqualified. I guess it prevents forming a Sub
library?
Yeah, i've read the docs for dune and it seems that if you want to have a local module - you have to use include_subdirs
and not define a lib.
By default include_subdirs
has value no
which prevents dune from using modules from subfolders. The value unqualified
allows it to use those modules.
I think it's important to have this project in valid state and available for newcomers to build.
Yeah, I'll merge this it's just that the include_subdirs
is a pretty uncommon feature. It would have been better to have it actually be a properly namespaced sub-library. You can see another simple example here: https://github.com/esy-ocaml/hello-reason
Thank you for the fix.
Running
make build
was causing:Added missing public_name for
sub
. Had to add emptysub.opam
to avoid an error:Had to remove the
lib/sub/jbuild
declaration that was makingsub
a library and used it as local module instead by settinginlude_subdirs unqualified
.