Add Reason upper bound for 0.12

reasonml / reason-react

Reason bindings for ReactJS

https://reasonml.github.io/reason-react/

MIT License

3.25k stars 349 forks source link

Add Reason upper bound for 0.12 #769

Open anmonteiro opened 1 year ago

anmonteiro commented 1 year ago

needs to have an upper bound < 3.10
patch 0.11 in opam with the same upper bound
make reactjs-jsx-ppx incompatible with reason-react >= 0.12
maybe use post-messages (like merlin)

jchavarri commented 1 year ago

patch 0.11 in opam with the same upper bound

Second item is being added in https://github.com/ocaml/opam-repository/pull/24367.

davesnx commented 1 year ago

1 and 2 are done. reason-react 0.11 and 0.12 have this {>= "3.6.0" & < "3.10.0"}

Would you add a conflict on reactjs-jsx-ppx?

anmonteiro commented 1 year ago

1 and 2 are done. reason-react 0.11 and 0.12 have this {>= "3.6.0" & < "3.10.0"}

Would you add a conflict on reactjs-jsx-ppx?

I think it should be fine, actually. People depend only on reason-react, which brings the ppx along as a a dependency. We don't expect this reactjs-jsx-ppx name to end up in their dependencies.

davesnx commented 1 year ago

I we don't mention reactjs-jsx-ppx I don't think people will face the issue also