search

reasonml / reason-react

Reason bindings for ReactJS
https://reasonml.github.io/reason-react/
MIT License
3.25k stars 349 forks source link

Move pipeablestream to new lib #815

Closed jchavarri closed 11 months ago

jchavarri commented 11 months ago

Fixes #814.

Adds a new library reason-react.node-only that only includes the binding to renderToPipeableStream and companion types and utilities.

anmonteiro commented 11 months ago

Why don't we make ReactDOMServer itself the entire separate library?

anmonteiro commented 11 months ago

Check https://github.com/reasonml/reason-react/pull/819 with a proposal.

I'm not a big fan of node-only since that also works in deno, bun, other runtimes.

Instead, my proposal separates the entire ReactDOMServer module to a new reason-react.dom-server library.

Let me know what you think.