reasonml / reason-react

Reason bindings for ReactJS
https://reasonml.github.io/reason-react/
MIT License
3.25k stars 349 forks source link

require melange 4 and udpate tests #836

Closed tatchi closed 4 months ago

tatchi commented 4 months ago

I had melange v4 installed when I did make init, which produces some diffs in tests. This is due to the var -> const change in melange v4. This PR suggests bumping the required melange version to avoid this.

I'm not a nix user, so I don't know if anything needs to be updated on that side.

jchavarri commented 4 months ago

Please check https://github.com/reasonml/reason-react/pull/833.

tatchi commented 4 months ago

My bad, I'm closing this one then