reasonml / reason

Simple, fast & type safe code that leverages the JavaScript & OCaml ecosystems
http://reasonml.github.io
MIT License
10.14k stars 429 forks source link

rtop doesn't work properly on windows #2261

Closed andreypopp closed 3 months ago

andreypopp commented 5 years ago

After #2167 rtop runs on Windows but there's a problem with it — the shell seems to not pass the control over stdin/stdout to the rtop command and input/output is interleaved between the shell and the rtop program.

Repro:

% npm install -g esy@0.4.0
% git clone https://github.com/andreypopp/hello-reason
% cd hello-reason
% git checkout rtop-on-windows
% git submodule init # bring reason repo
% git submodule update
% esy
% esy utop # works!
% esy rtop # launches but doesn't work

I tested this with cmd.exe own terminal and ConEmu running cmd.exe.

cc @ulrikstrid as you worked on fixing #2167

anmonteiro commented 3 months ago

Please reopen if there’s still an issue. The windows tests for rtop seem to be passing