search

reasonml / reason

Simple, fast & type safe code that leverages the JavaScript & OCaml ecosystems
http://reasonml.github.io
MIT License
10.12k stars 428 forks source link

Support OCaml 4.11 #2582

Closed anmonteiro closed 4 years ago

anmonteiro commented 4 years ago

This is an early PR that will hopefully allow us to support OCaml 4.11 when it's out (it's in alpha right now).

This is not expected to build, as it's currently dependent on https://github.com/let-def/merlin-extend/pull/13 being merged.

hhugo commented 4 years ago

Note that there is a new syntax for string litteral in 4.11

kit-ty-kate commented 4 years ago

For information, OCaml 4.11 is going to be released next week

jordwalke commented 4 years ago

@hhugo Where can I read about this string literal syntax?

anmonteiro commented 4 years ago

This is the PR for quoted extensions: https://github.com/ocaml/ocaml/pull/8820.

I didn't add support for it because it might warrant its own syntax discussion, so I'll leave that to people who care about those discussions. It doesn't add new AST nodes, so in the worst case we'll print them as strings today.

I'm gonna go ahead and merge this, based on the justification above.

jordwalke commented 4 years ago

so in the worst case we'll print them as strings today.

I suspect it will just print them as quoted strings with extension points surrounding them.