reasonml / reason

Simple, fast & type safe code that leverages the JavaScript & OCaml ecosystems
http://reasonml.github.io
MIT License
10.09k stars 424 forks source link

Fixes Windows CI: prepend '/c/Program Files/Git/bin' #2611

Closed ManasJayanth closed 3 years ago

ManasJayanth commented 4 years ago

Bash@3 started failing after a recent change related to WSL

https://github.com/actions/virtual-environments/pull/1081 https://github.com/actions/virtual-environments/pull/1276

This PR ensure bash.exe is picked from Git Bash

ManasJayanth commented 4 years ago

Thanks @-phated for the idea

ManasJayanth commented 4 years ago

🙌

jordwalke commented 4 years ago

Thank you @phated and @prometheansacrifice. I incorporated the fixes into this PR: https://github.com/facebook/reason/pull/2605 I'll merge the other one if it's ready within the day, else merge this one.