search

reasonml / reason

Simple, fast & type safe code that leverages the JavaScript & OCaml ecosystems
http://reasonml.github.io
MIT License
10.09k stars 424 forks source link

fix object type inherit when using modules #2613

Closed EduardoRFS closed 3 years ago

EduardoRFS commented 4 years ago

The syntax for object inheritance on types should be any core_type valid, as in OCaml, that is important because of valid types like Module.t(param)

type x = {. ...Module.t(param)}

OCaml also does that, as it's shown at https://github.com/ocaml/ocaml/blob/trunk/parsing/parser.mly#L3399

facebook-github-bot commented 4 years ago

Hi @EduardoRFS!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 4 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

jordwalke commented 3 years ago

Thank you @EduardoRFS !