search

reasonml / reason

Simple, fast & type safe code that leverages the JavaScript & OCaml ecosystems
http://reasonml.github.io
MIT License
10.09k stars 424 forks source link

Migrate test.sh to Rely #2616

Closed davesnx closed 1 year ago

davesnx commented 3 years ago

Hey,

I'm opening this PR as the continuation of https://github.com/facebook/reason/pull/2454 in order to land it. I manually cherry-picked @sync commits on top to avoid conflicts and finished a few test.sh logic into rely.

I'm not a contributor to facebook/reason, well, now a little, but I'm not familiar with the dev experience on this project. So feel free to checkout and try it out to give me any hint that can be beneficial now.

Most of the structure was discussed in https://github.com/facebook/reason/pull/2454 with some extras

jordwalke commented 3 years ago

PS. There are currently 2 tests failing regarding typechecking features from ocaml4.08. I saw that on the previous bash script were skipped, just opening with the failing tests to validate it's correct.

I'm confused here. Does master branch have failing tests but they're being skipped on 4.08? I think we have some opam CI that does run more versions just to catch these issues (we should also build with different esy ocaml versions perhaps)

davesnx commented 3 years ago

Yep, the 2 tests are failing in my diff. Since they meant to run only on > 4.08 and I didn't have this logic working ok.

jordwalke commented 3 years ago

Any luck with the opam pins?