search

reasonml / reason

Simple, fast & type safe code that leverages the JavaScript & OCaml ecosystems
http://reasonml.github.io
MIT License
10.14k stars 428 forks source link

ocaml-migrate-parsetree 2.0 #2621

Closed EduardoRFS closed 4 years ago

EduardoRFS commented 4 years ago

OMP 2.0 was launched and we got some breaking changes, so if you try it now it's not working with esy, also we probably need a release, maybe as 3.6.1

{
  "dependencies": {
    "@opam/dune": "2.6.2",
    "ocaml": "4.10.0",
    "@esy-ocaml/reason": "3.6.0"
  }
}

@jordwalke @anmonteiro

anmonteiro commented 4 years ago

Why are there breaking changes? https://github.com/ocaml/opam-repository/pull/16999 fixed this upstream.

anmonteiro commented 4 years ago

Is it perhaps a problem in the releases to NPM? That's a world I don't know anything about.

EduardoRFS commented 4 years ago

@anmonteiro OMP 2.0 is something completely different as you can see here

https://discuss.ocaml.org/t/ppx-omp-2-0-0-and-next-steps/6231/2

So we need to keep the version in control and it's broken on our npm release, so we need a 3.6.1 to address that, but even if we're using a resolution that will break on esy as esy will choose the most recent version

anmonteiro commented 4 years ago

I'm aware it's different, I was mentioning that the upper bound was added in OPAM. If it's needed for NPM, I'll defer to Jordan.

smorimoto commented 4 years ago

I have the same opinion as @EduardoRFS, and I suspect that we have a problem with this.

EduardoRFS commented 4 years ago

Closed in favor of #2622