search

reasonml / reason

Simple, fast & type safe code that leverages the JavaScript & OCaml ecosystems
http://reasonml.github.io
MIT License
10.09k stars 424 forks source link

Bumps deps #2628

Closed Et7f3 closed 3 years ago

Et7f3 commented 3 years ago

This PR allow to compile it with 4.11. It just need to be released on npm.

Relevant diff: https://github.com/facebook/reason/pull/2628/files/4c3336f0ab875d38eebef67dd24f61df3ddf295b

Ok so ubuntu 16.04 can't have glibc 2.27 I have bumped ubuntu image and it worked :white_check_mark:

ci failure: maybe try to used old ubuntu with a esy compiled with a glibc < 2.27. @jordwalke PR is ready to review and can be released.

Et7f3 commented 3 years ago

I think it is just ubuntu that is broken: I have tried old dune (< 2.0.0) and get error.

anmonteiro commented 3 years ago

superseded by https://github.com/facebook/reason/pull/2639