reasonml / reasonml.github.io

Reason's documentation site
https://reasonml.github.io
MIT License
331 stars 398 forks source link

Melange playground #758

Open davesnx opened 10 months ago

davesnx commented 10 months ago

Since Melange released a new playground we could integrate it with the current ReasonML website, either with a redirect or embed it directly.

JavaScript and Native compilations are topics that are spreaded across the website, and it's a must fix. Either of the solution we choose, would be nice to have it clear for users to understand Reason + Melange -> JS, Reason + dune -> native.

This issue will be used as an umbrella for all issues related with current Playground:

davesnx commented 10 months ago

Preferred solution would be to showcase both playgrounds: sketch.sh and melange.re as a page.

and remove/deprecated the current playground/refmt.js

jchavarri commented 10 months ago

ftr https://github.com/Sketch-sh/sketch-sh/issues/371.

jchavarri commented 10 months ago

I just tried in the melange playground all the referred issues that were crashing in the reason playground, and all seem to work fine now:

Issue Code Melange playground link
#604 type x = A{x: int}; Link
#607 type t = \| Hi({name: string}); Link
#544 Js.log(0x lxor 0x80000000);Js.log(19 lxor 0x40000000); Link
#661 let a : int = 1s; Link

Maybe we can close those with a note directly?

davesnx commented 10 months ago

Once we fix this issue, totally!