Closed delphisharp closed 5 months ago
已重新提交代码。 本地测试通过。 Code has been resubmitted. The local pytest passed.
Due to code format reasons, resubmit.
Attention: 9 lines
in your changes are missing coverage. Please review.
Comparison is base (
0823bf2
) 99.50% compared to head (d49cdb0
) 99.10%. Report is 1 commits behind head on master.:exclamation: Current head d49cdb0 differs from pull request most recent head c904f09. Consider uploading reports for the commit c904f09 to get more accurate results
Files | Patch % | Lines |
---|---|---|
sqllineage/config.py | 80.48% | 8 Missing :warning: |
sqllineage/core/models.py | 80.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
我感觉你这个改动有点问题呀,你现在的写法不支持环境变量的配置了。
I feel there is something wrong with your change. Your current writing method does not support the configuration of environment variables.
https://github.com/reata/sqllineage/pull/540
我正在通过环境变量的方式配置是否启用 列别名引用功能
I am configuring whether to enable the lateral column alias reference function through environment variables.
我感觉你这个改动有点问题呀,你现在的写法不支持环境变量的配置了。
I feel there is something wrong with your change. Your current writing method does not support the configuration of environment variables.
540
我正在通过环境变量的方式配置是否启用 列别名引用功能
I am configuring whether to enable the lateral column alias reference function through environment variables.
Agreed, we need to maintain support config through environment variables. This approach is read only.
The new ability we're adding through this PR is to set config at run time via Python code.
刚才在添加测试用例,各位意见现在看到了。我总结下:
I was adding test cases just now, and your comments are now visible. Let me summarize:
Fix the issue and commit the code. The unit test passes.
Dear ALL:
目前模型的默认模式名是通过环境变量传递的,我认为实现方法不够python。 所以,我实现了另一种解决方法。
Currently the default schema name of the model is passed through environment variables, and I think the implementation method is not python enough. So, I implemented another workaround.