reaviz / reablocks

🧩 Component Library for React based on Tailwind. Maintained by @goodcodeus.
https://reablocks.dev
Apache License 2.0
131 stars 10 forks source link

Tabs styles #182

Closed evgenoid closed 3 months ago

evgenoid commented 6 months ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[x] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Issue Number: GOOD-168

Does this PR introduce a breaking change?

[ ] Yes
[x] No
Screenshot 2024-05-14 at 15 24 08 Screenshot 2024-05-14 at 15 24 18
netlify[bot] commented 6 months ago

Deploy Preview for reablocks-storybook ready!

Name Link
Latest commit 64b554fb62c97eea13201954cebe452754eefd2c
Latest deploy log https://app.netlify.com/sites/reablocks-storybook/deploys/66435863ab69d80008733080
Deploy Preview https://deploy-preview-182--reablocks-storybook.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

evgenoid commented 6 months ago

@ghsteff what we decided with this one?

ghsteff commented 6 months ago

@ghsteff what we decided with this one?

So the tertiary tab variant looks pretty much the same as our button group which could be confusing if you use both of these in the same app. But this is a nice variant of tab to have pre-built 🤔

You know how we have some stories called CustomTheme? Maybe having this tertiary tab variant as a CustomTheme story would make the most sense because it's saying "This doesn't necessarily match our default theme, but it's one example of a way you could style this"

You think some designs would use all these tab variants in one app?