add aria-labels for close buttons on dialog and drawer

steppy452 commented 4 months ago

PR Checklist

Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[x] Other... Please describe: accessibility update - adding aria-labels

What is the current behavior?

Issue Number: N/A Close buttons but dialog and drawers just shows x instead of something that's more useful for screen readers

What is the new behavior?

Close button for dialogs and drawers now have a more explicit aria-label

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
reablocks-storybook	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 20, 2024 5:41pm

netlify[bot] commented 4 months ago

Deploy Preview for reablocks-storybook ready!

Name	Link
Latest commit	bc7299844d6ff8411e759cefa29a9988221a31e4
Latest deploy log	https://app.netlify.com/sites/reablocks-storybook/deploys/667469b84b8ccf00080547b4
Deploy Preview	https://deploy-preview-233--reablocks-storybook.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

reaviz / reablocks