search

reaviz / reaflow

🎯 React library for building workflow editors, flow charts and diagrams. Maintained by @goodcodeus.
https://reaflow.dev
Apache License 2.0
2.06k stars 119 forks source link

Error during installation #100

Open Nerevar123 opened 3 years ago

Nerevar123 commented 3 years ago

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Other... Please describe:

Current behavior

When installed via 'npm i reaflow' got errors:

npm WARN ERESOLVE overriding peer dependency npm WARN Found: framer-motion@4.1.17 npm WARN node_modules/framer-motion npm WARN framer-motion@"^4.1.4" from reaflow@4.2.1 npm WARN node_modules/reaflow npm WARN reaflow@"*" from the root project npm WARN npm WARN Could not resolve dependency: npm WARN peer framer-motion@"^3.0.0" from rdk@5.1.3 npm WARN node_modules/rdk npm WARN rdk@"^5.1.3" from reaflow@4.2.1 npm WARN node_modules/reaflow npm ERR! code ERESOLVE npm ERR! ERESOLVE unable to resolve dependency tree npm ERR! npm ERR! Found: react@17.0.2 npm ERR! node_modules/react npm ERR! peer react@"*" from @testing-library/react@11.2.7 npm ERR! node_modules/@testing-library/react npm ERR! @testing-library/react@"^11.1.0" from the root project npm ERR! peer react@"17.0.2" from react-dom@17.0.2 npm ERR! node_modules/react-dom npm ERR! peer react-dom@"*" from @testing-library/react@11.2.7 npm ERR! node_modules/@testing-library/react npm ERR! @testing-library/react@"^11.1.0" from the root project npm ERR! react-dom@"^17.0.2" from the root project npm ERR! 4 more (reaflow, framer-motion, rdk, reakeys) npm ERR! 9 more (react-scripts, recoil, the root project, reaflow, ...) npm ERR! npm ERR! Could not resolve dependency: npm ERR! peer react@"^16.3.0" from react-scrolllock@5.0.1 npm ERR! node_modules/rdk/node_modules/react-scrolllock npm ERR! react-scrolllock@"^5.0.1" from rdk@5.1.3 npm ERR! node_modules/rdk npm ERR! rdk@"^5.1.3" from reaflow@4.2.1 npm ERR! node_modules/reaflow npm ERR! reaflow@"*" from the root project npm ERR! npm ERR! Fix the upstream dependency conflict, or retry npm ERR! this command with --force, or --legacy-peer-deps npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Full report: eresolve-report.txt

It was possible to install successfully only with --legacy-peer-deps flag.

Minimal reproduction of the problem with instructions

cmd => npm i reaflow

Environment


Libs:
- react version: 17.0.2


Browser:
- [x] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX

For Tooling issues:
- Node version: 16.5.0
- NPM version: 7.20.2
- Platform:  Windows
amcdnl commented 3 years ago

Thanks for reporting. Can you share the react versions you are using?

Nerevar123 commented 3 years ago

Libs:

  • react version: 17.0.2
  • Node version: 16.5.0
  • NPM version: 7.20.2
mike-oakley commented 2 years ago

Hey @amcdnl any update on this? Not supporting React 17 is a bit of a deal breaker. Thanks!

amcdnl commented 2 years ago

It supports React 17 - in fact the storybook runs on 17.

It looks like this issue is stuck at @testing-library/react@11.2.7. This was updated recently but I went ahead and bumped it again this morning. Can you retry on latest version?

mike-oakley commented 2 years ago

Thanks for taking a look, but 4.2.3 still has the same problem for me. I'm no expert but to me it looks like the problem is with react-scrolllock in rdk which is pinned to react ^16.3.0. Unfortunately it doesn't look like that package has been updated for a while and there is already an issue open from Feb with no response (https://github.com/jossmac/react-scrolllock/issues/85).

amcdnl commented 2 years ago

Got it! OK - I should be able to fork that and publish a version that supports this to resolve this issue.

leonbloy commented 2 years ago

Same problem here

sandrooco commented 2 years ago

This project seems dead - has anyone got a good alternative?

amcdnl commented 2 years ago

@sandrooco - Not dead - just busy. Happy to accept any PRs though.

sandrooco commented 2 years ago

@sandrooco - Not dead - just busy. Happy to accept any PRs though.

I just figured that I'm not in the react-scrolllock repo - I'm so sorry! Thanks for your work.

amcdnl commented 2 years ago

@sandrooco - We can move off that scrolllock to something else ( but that is in reaviz/rdk - not this project - but this project uses it internally ). Let me know what you figure out...