Open barrymichaeldoyle opened 5 months ago
When implementing a theme toggle functionality. i.e. changing from one theme to another during runtime. The graph does not update all the colors.
Implement a toggle feature in the app as follows (you can use the default light and dark themes)
return ( <GraphCanvas actives={actives} draggable layoutType="hierarchicalLr" cameraMode="pan" edges={edges} nodes={nodes} onCanvasClick={onCanvasClick} onNodeClick={handleNodeClick} ref={graphRef} selections={selections} theme={theme === "light" ? lightTheme : darkTheme} edgeInterpolation="linear" /> )
You will see the same problem effective even if you just update the theme during development and watch it incorrectly re-render with HMR
I obviously expect that updating a theme during runtime should update all theme values and not just some.
Light Theme Example:
Dark Theme Example:
What happens when changing from light to dark (BAD):
What happens when changing from dark to light (BAD):
No response
I am also having this issue
Describe the bug
When implementing a theme toggle functionality. i.e. changing from one theme to another during runtime. The graph does not update all the colors.
Steps to Reproduce the Bug or Issue
Implement a toggle feature in the app as follows (you can use the default light and dark themes)
You will see the same problem effective even if you just update the theme during development and watch it incorrectly re-render with HMR
Expected behavior
I obviously expect that updating a theme during runtime should update all theme values and not just some.
Screenshots or Videos
Light Theme Example:
Dark Theme Example:
What happens when changing from light to dark (BAD):
What happens when changing from dark to light (BAD):
Platform
Your Example Website or App
No response
Additional context
No response