Add type defs to internal Comparable module in Map/Set

reazen / relude

FP-inspired prelude/standard library for ReasonML projects

https://reazen.github.io/relude

MIT License

267 stars 41 forks source link

Add type defs to internal Comparable module in Map/Set #309

Closed johnhaley81 closed 3 years ago

johnhaley81 commented 3 years ago

When using maps and sets, the type definition for the internal comparable is obfuscated so it cannot be used in any other context (even if the types should line up). For example, if you try to use the key of a String.Map as a string you will get a type error.

Adding the type defs to the module definition is a simple fix that will allow this functionality.

johnhaley81 commented 3 years ago

@andywhite37 @mlms13 not exactly sure why the coverage test is failing on this :|

andywhite37 commented 3 years ago

It seems like bisect_ppx is busted - wasn't there a problem with that from awhile ago? I'm okay to merge this - I'll push up a new release later tonight.

johnhaley81 commented 3 years ago

Thanks! Should we just rip that out?

johnhaley81 commented 3 years ago

@andywhite37 friendly ping on a possible release? 🙏